Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Flytectl get started added for running example #58

Merged
merged 1 commit into from
May 27, 2021
Merged

Flytectl get started added for running example #58

merged 1 commit into from
May 27, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Apr 27, 2021 •
edited
Loading

TL;DR

  • Added Get started guide for registering first workflow

For testing examples are available at https://github.com/flyteorg/flytesnacks/releases/tag/v0.2.89

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

flyteorg/flytesnacks#166
flyteorg/flyte#942

@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #58 (95cfef8) into master (658f23c) will increase coverage by 4.71%.
The diff coverage is 85.21%.

❗ Current head 95cfef8 differs from pull request most recent head ff92c84. Consider uploading reports for the commit ff92c84 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   45.98%   50.69%   +4.71%     
==========================================
  Files          35       40       +5     
  Lines        1046     1150     +104     
==========================================
+ Hits          481      583     +102     
- Misses        491      500       +9     
+ Partials       74       67       -7
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/get/launch_plan_util.go 70.37% <0.00%> (ø)
cmd/update/namedentityconfig_flags.go 29.41% <29.41%> (ø)
cmd/update/launch_plan.go 54.54% <54.54%> (ø)
cmd/create/execution.go 73.91% <71.42%> (+18.35%) ⬆️
cmd/create/execution_util.go 87.25% <96.29%> (+17.48%) ⬆️
cmd/create/executionconfig_flags.go 40.00% <100.00%> (+3.15%) ⬆️
cmd/get/execution.go 92.59% <100.00%> (-1.35%) ⬇️
cmd/get/execution_util.go 46.96% <100.00%> (+9.46%) ⬆️
cmd/get/get.go 100.00% <100.00%> (ø)
cmd/get/launchplanconfig_flags.go 29.41% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 658f23c...ff92c84. Read the comment docs.

@yindia yindia changed the title [WIP] Flytectl get started added for running example Flytectl get started added for running example Apr 29, 2021
@yindia yindia marked this pull request as ready for review April 29, 2021 15:14
@yindia yindia requested a review from pmahindrakar-oss April 29, 2021 15:15
@pmahindrakar-oss
Copy link
Contributor

pmahindrakar-oss commented May 3, 2021 •
edited
Loading

@evalsocket You would need to sign the commits using the GPG keys for this repo. Hence the merge is blocked.
Whenver you get time you can setup this for your account . Follow the instructions from this page https://docs.github.com/en/github/authenticating-to-github/about-commit-signature-verification
which is the same one from merging is blocked label above.

Also if possible once you are able to do this , Can you add this to Getting started page so the contributors are aware of this new change.

@yindia
Copy link
Contributor Author

yindia commented May 4, 2021

@pmahindrakar-oss let's merge it after flytesnack release

@pmahindrakar-oss
Copy link
Contributor

Ping me or @kumare3 to merge it once the aritifacts are available for flytesnacks. And also instead of going of a static version can this pick whats the latest available.

@yindia yindia changed the title Flytectl get started added for running example [WIP] Flytectl get started added for running example May 6, 2021
@yindia
Copy link
Contributor Author

yindia commented May 26, 2021 •
edited
Loading

@pmahindrakar-oss @kumare3 flytesnacks examples are available in the new release, you can merge it https://github.com/flyteorg/flytesnacks/releases/tag/v0.2.89

katrogan
katrogan previously approved these changes May 26, 2021
View reviewed changes
katrogan
katrogan reviewed May 26, 2021
View reviewed changes
README.md Outdated

```bash
# Run Core workflows
$ flytectl register files https://github.com/flyteorg/flytesnacks/release/releases/download/v0.2.89/flytesnacks-core.tgz -d development -p flytesnacks --archive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this download the latest release version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katrogan that would be hard, as the semantics of the release URL are not know to flytectl
IMO @pmahindrakar-oss, @katrogan we should probably have a different cli target

flytectl register examples --version v0.2.89
# OR defaults to latest if --version is not provided?

Copy link
Contributor

@pmahindrakar-oss pmahindrakar-oss May 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also now that we have multiple modules and each with its own archive then we would additionally need option for that too. eg : https://github.com/flyteorg/flytesnacks/releases/download/v0.2.89/flytesnacks-integrations-hive.tgz.
All examples can currently be registerd by passing list of archives in the same command

@kumare3
Copy link
Contributor

kumare3 commented May 26, 2021

this did not work for me

flytectl register files https://github.com/flyteorg/flytesnacks/release/releases/download/v0.2.89/flytesnacks-core.tgz -d development -p flytesnacks --archive
INFO[0000] Using config file: [/Users/ketanumare/.flyte/config.yaml]
INFO[0000] Config section [root] updated. No update handler registered.  src="viper.go:349"
INFO[0000] Config section [logger] updated. Firing updated event.  src="viper.go:351"
Error: unexpected EOF

➜ flytectl version
INFO[0000] Using config file: [/Users/ketanumare/.flyte/config.yaml]
INFO[0000] Config section [admin] updated. Firing updated event.  src="viper.go:351"
INFO[0000] Config section [storage] updated. No update handler registered.  src="viper.go:349"
INFO[0000] Config section [adminutils] updated. No update handler registered.  src="viper.go:349"
INFO[0000] Config section [root] updated. No update handler registered.  src="viper.go:349"
INFO[0000] Config section [logger] updated. Firing updated event.  src="viper.go:351"
{
  "App": "flytectl",
  "Build": "cdc1938",
  "Version": "0.1.8",
  "BuildTime": "2021-05-26 15:26:36.030606 -0700 PDT m=+0.013616840"
}{
  "App": "controlPlane",
  "Build": "db32bb3",
  "Version": "v0.5.4",
  "BuildTime": "2021-05-21 00:11:58.498302524 +0000 UTC m=+0.028839574"
}

@kumare3
Copy link
Contributor

kumare3 commented May 26, 2021

The reason for the failure - bad path @evalsocket -

flytectl register files -d development -p flytesnacks --archive https://github.com/flyteorg/flytesnacks/releases/download/v0.2.89/flytesnacks-core.tgz

worked!

@yindia yindia changed the title [WIP] Flytectl get started added for running example Flytectl get started added for running example May 27, 2021
@pmahindrakar-oss pmahindrakar-oss merged commit e2a8d11 into flyteorg:master May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmahindrakar-oss pmahindrakar-oss pmahindrakar-oss approved these changes

@katrogan katrogan katrogan left review comments

@EngHabu EngHabu Awaiting requested review from EngHabu EngHabu is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yindia @pmahindrakar-oss @kumare3 @katrogan